db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3235) Implement the replication stop functionality
Date Wed, 19 Dec 2007 03:32:43 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

V.Narayanan updated DERBY-3235:
-------------------------------

    Attachment: StopImplementation_v2.stat
                StopImplementation_v2.diff

Thank you for the comments on the patch Oystein.

>Thanks for the patch Narayanan. It looks good. Will there be more 
>code coming for clean-up of the slave? (I see there is a todo tag in 
>StopSlave, but I am not quite sure what needs to be done.)

I have posted a preliminary patch for failover in which I have posted implementation
for logToFile.stopReplicationSlaveRole. The other todos will be addressed in incremental
patches. I will move the stopReplicationRole implementation to this patch if the community
feels that is the better way to do. I however do not see much difference however since the

code is not used for now.

>Why is AsynchronousLogShipper#flushBuffer not synchronized while 
>shipALogChunk is? Another question is whether these two methods could 
>share some code. Could flushBuffer be implemented as 
>"while(shipALogChunk());"? 

Agreed! Implemented in the suggested way.

>One minor issue: Javadoc for stopMaster() says that it throws 
>StandardException. It does not.

fixed!

> Implement the replication stop functionality
> --------------------------------------------
>
>                 Key: DERBY-3235
>                 URL: https://issues.apache.org/jira/browse/DERBY-3235
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Replication
>    Affects Versions: 10.4.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: StopImplementation_v1.diff, StopImplementation_v1.stat, StopImplementation_v1_NotForCommit.diff,
StopImplementation_v1_NotForCommit.stat, StopImplementation_v2.diff, StopImplementation_v2.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message