Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 13147 invoked from network); 25 Nov 2007 22:41:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Nov 2007 22:41:52 -0000 Received: (qmail 41092 invoked by uid 500); 25 Nov 2007 22:41:40 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 40922 invoked by uid 500); 25 Nov 2007 22:41:39 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 40913 invoked by uid 99); 25 Nov 2007 22:41:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Nov 2007 14:41:39 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [192.18.6.24] (HELO gmp-eb-mail-2.sun.com) (192.18.6.24) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Nov 2007 22:41:40 +0000 Received: from fe-emea-09.sun.com (gmp-eb-lb-2-fe2.eu.sun.com [192.18.6.11]) by gmp-eb-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id lAPMfJ0g014424 for ; Sun, 25 Nov 2007 22:41:19 GMT Received: from conversion-daemon.fe-emea-09.sun.com by fe-emea-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JS300H012Y8FO00@fe-emea-09.sun.com> (original mail from Dag.Wanvik@Sun.COM) for derby-dev@db.apache.org; Sun, 25 Nov 2007 22:41:19 +0000 (GMT) Received: from khepri23.norway.sun.com ([129.159.112.235]) by fe-emea-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JS300L2P30U1U00@fe-emea-09.sun.com> for derby-dev@db.apache.org; Sun, 25 Nov 2007 22:41:19 +0000 (GMT) Date: Sun, 25 Nov 2007 23:41:18 +0100 From: Dag.Wanvik@Sun.COM (Dag H. Wanvik) Subject: Re: [jira] Reopened: (DERBY-3211) Convert derbynet/NSinSameJVM.java to junit In-reply-to: <7323077.1195906843217.JavaMail.jira@brutus> Sender: Dag.Wanvik@Sun.COM To: derby-dev@db.apache.org Message-id: MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT References: <7323077.1195906843217.JavaMail.jira@brutus> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (usg-unix-v) X-Virus-Checked: Checked by ClamAV on apache.org "Knut Anders Hatlen (JIRA)" writes: > [ https://issues.apache.org/jira/browse/DERBY-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Knut Anders Hatlen reopened DERBY-3211: > --------------------------------------- > > > Reopening the issue since there are some remaining problems: > > 1) Dan's comment about try/catch/println is not addressed. As the test is written now, JUnit won't ever notice if the test fails, since all exceptions are swallowed. > > 2) I don't think the port number and host name should be hard coded > in the test. Instead of "localhost", TestConfiguration.getHostName() > should be used. Also, I think we need to add a method to > TestConfiguration called getAlternativePort() or something, instead > of hard coding the port number 20000 in the test. The point of > centralizing the allocation of port numbers in TestConfiguration, is > to enable people to run multiple JUnit tests in parallel on the same > machine without conflicting with each other (there was an effort > some time ago to achieve this, I don't remember how far they I did some work on this, and at that point in time, no tests used any port except the one found in TestConfiguration. I verified this by tracing the server code opening the port. This state of things may have deteriorated since, though. Thanks, Dag