Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <9305406.1196414443033.JavaMail.jira@brutus>
Date: Fri, 30 Nov 2007 01:20:43 -0800 (PST)
From: "Ole Solberg (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-2807) Create a test for BlobClob
 compatibility on Derby server versions vs. Derby client versions.
In-Reply-To: <13442226.1181641406119.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547052 ] 

Ole Solberg commented on DERBY-2807:
------------------------------------

> Dyre Tjeldvoll commented on DERBY-2807:
> ---------------------------------------
> 
> Ole: "I am attaching an example 'compatibilitytest.properties' file." 
> 
> So this file is not part of the patch, then? 
Correct.

> Seems like there is a lot of information in it. Would it not be good to have it in the repository? 
The property file is also described in org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.CompatibilityCombinations where it is used. To avoid duplicating information I think that description should be used. (I guess I could have referred to that description instead of introducing the example file...)

> But since you need it to be in the directory where JUnit is started, you would then need to copy it manually from your sandbox to where you run the test. 
> Would it be possible to specify to specify the location of this file on the command line somehow? 

Good idea! I will implement that - in another patch if that is ok?


> 
> Some nits:
> The new defaultExistingServerDecorator() seems to have inherited the same "This looks bogus to me..." comment that was mentioned by someone else in another context.  
1. I will remove that inherited comment. It's already commented that defaultExistingServerDecorator() is a variant of defaultServerDecorator() where that comment is originally given.

> In that method, there are also some code that has been commented out, and it is not obvious (to me at least) why this has been done 
> (is it a temporary workaround for something that will be fixed later?).
2. " /* && Derby.hasServer() */ " was commented out because in this case we do not require the server jar to be present: With the server already started we don't need server in the classpath and thus to test for server.
I'll remove that /* .. */ comment.

I will upload a new a new patch with 1. and 2.


> Create a test for BlobClob compatibility on Derby server versions vs. Derby client versions.
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2807
>                 URL: https://issues.apache.org/jira/browse/DERBY-2807
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.1.4
>            Reporter: Ole Solberg
>            Assignee: Ole Solberg
>            Priority: Minor
>         Attachments: compatibilitytest.properties, derby-2807-v1.diff.txt
>
>
> Run '..../tests/jdbcapi/BlobClob4BlobTest.java' in the 'java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/CompatibilityCombinations.java' framework to test combinations of Derby server versions vs. Derby client versions. The CompatibilityCombinations framework also allows varying the JVM version used on the server and client side.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.