Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 38724 invoked from network); 30 Nov 2007 22:02:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Nov 2007 22:02:01 -0000 Received: (qmail 32768 invoked by uid 500); 30 Nov 2007 22:01:48 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 32743 invoked by uid 500); 30 Nov 2007 22:01:48 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 32734 invoked by uid 99); 30 Nov 2007 22:01:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2007 14:01:48 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [192.18.43.133] (HELO sca-es-mail-2.sun.com) (192.18.43.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2007 22:01:50 +0000 Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id lAUM1Sn4025660 for ; Fri, 30 Nov 2007 14:01:28 -0800 (PST) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JSC00J01AFPN300@fe-sfbay-10.sun.com> (original mail from Martin.Zaun@Sun.COM) for derby-dev@db.apache.org; Fri, 30 Nov 2007 14:01:28 -0800 (PST) Received: from [192.168.0.3] ([68.183.202.246]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JSC005M3AIDA650@fe-sfbay-10.sun.com> for derby-dev@db.apache.org; Fri, 30 Nov 2007 14:01:25 -0800 (PST) Date: Fri, 30 Nov 2007 14:01:54 -0800 From: Martin Zaun Subject: copy&paste bug in BaseMonitor? Sender: Martin.Zaun@Sun.COM To: derby-dev@db.apache.org Message-id: <47508852.8080706@sun.com> Organization: Sun Microsystems, Inc. MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070509 SeaMonkey/1.1.2 X-Virus-Checked: Checked by ClamAV on apache.org Hi, a particular line of code java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java:1086 very much looks like a copy&paste bug to me: private Vector getImplementations(Properties moduleList, boolean actualModuleList) { ... if (key.startsWith(Property.MODULE_PREFIX)) { tag = key.substring(Property.MODULE_PREFIX.length()); } else if (key.startsWith(Property.SUB_SUB_PROTOCOL_PREFIX)) { tag = key.substring(Property.MODULE_PREFIX.length()); ^^^^^^^^^^^^^ } ... I guess MODULE_PREFIX was meant to be replaced with SUB_SUB_PROTOCOL_PREFIX. Comments? Regards, Martin