Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <29284971.1194383931061.JavaMail.jira@brutus>
Date: Tue, 6 Nov 2007 13:18:51 -0800 (PST)
From: "Mamta A. Satoor (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-3178) DataSourceTest uses
 ConnectionEventListener but never verifies that events are getting fired
In-Reply-To: <26127517.1194368930884.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor updated DERBY-3178:
-----------------------------------

    Attachment: DERBY_3178_diff_ver1_Nov_06_2007.txt

Committed attached patch DERBY_3178_diff_ver1_Nov_06_2007.txt to trunk using revision 592544. The commit comments which describes the fix are as follows

DERBY-3178
This commit modifies DataSourceTest.java to ensure that expected Connection events are fired to the
ConnectionEventListener. The changes have been implemented by having AssertEventCatcher in DataSourceTest.java keep track of what events it received. This state is kept in boolean gotConnectionClosed and boolean gotConnectionErrorOccured flags in AssertEventCatcher. The test then checks the state of AssertEventCatcher after the test has done firing the events to make sure AssertEventCatcher got the expected events.


> DataSourceTest uses ConnectionEventListener but never verifies that events are getting fired
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3178
>                 URL: https://issues.apache.org/jira/browse/DERBY-3178
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY_3178_diff_ver1_Nov_06_2007.txt
>
>
> Derby has a junit test called DataSourceTest in jdbcapi package. This test registers ConnectionEventListener for various Connection objects but never verifies that events from those Connection objects are getting delivered to the listeners. Prior to this test's conversion to junit, there were System.out.println in the test but since this test is not cannon based anymore, those printlns have been commented out. I will soon submit a patch where this test will have asserts to make sure that Connection events are getting fired.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.