Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
From: "James F. Adams" <james.f.adams@comcast.net>
To: <derby-dev@db.apache.org>
Subject: RE: [jira] Assigned: (DERBY-3157) Lexical error (EOF) when comment
 consists of a single character
Date: Sun, 25 Nov 2007 20:57:02 -0800
Message-ID: <000001c82fe8$c9733d30$0b00a8c0@speedy>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Importance: Normal
Thread-Index: Acgvs9F3UsrjLwoZTM65rMZoC9PIlAAMraQg
In-Reply-To: <x1oxir3q3qau.fsf@sun.com>

Dag,

The patch collapses the single character productions used to search for
DERBY-PROPERTIES and seems to take care of the specified cases.

However, the following input in lang/optimizerOverrides.sql

select * from t1 --derby-properties
;

Generates:

ERROR 42X01: Syntax error: Encountered "<EOF>" at line 2, column 35.

Instead of:

ERROR XCY04: Invalid syntax for optimizer overrides. The syntax should =
be --
DERBY-PROPERTIES propertyName =3D value [, propertyName =3D value]*

When run using the DerbyNetClient framework.  The test passes when using =
the
embedded framework.  I never determined what caused this change in
behaviour.

-----Original Message-----
From: Dag.Wanvik@Sun.COM [mailto:Dag.Wanvik@Sun.COM]=20
Sent: Sunday, November 25, 2007 2:37 PM
To: derby-dev@db.apache.org
Subject: Re: [jira] Assigned: (DERBY-3157) Lexical error (EOF) when =
comment
consists of a single character


"James F. Adams (JIRA)" <jira@apache.org> writes:

>      [=20
> =
https://issues.apache.org/jira/browse/DERBY-3157?page=3Dcom.atlassian.ji
> ra.plugin.system.issuetabpanels:all-tabpanel ]
>
> James F. Adams reassigned DERBY-3157:
> -------------------------------------
>
>     Assignee:     (was: James F. Adams)

I see you unassigned yourself, James. You posted a patch, which I =
apparent=F8y
still has some problems, could you comment on what residual issues there
might be with it, or do you consider it a dead end? (I didn't look =
closely
at it ;)

Thanks,
Dag

>
>> Lexical error (EOF) when comment consists of a single character
>> ---------------------------------------------------------------
>>
>>                 Key: DERBY-3157
>>                 URL: https://issues.apache.org/jira/browse/DERBY-3157
>>             Project: Derby
>>          Issue Type: Bug
>>          Components: SQL
>>    Affects Versions: 10.3.1.4, 10.4.0.0
>>            Reporter: Knut Anders Hatlen
>>            Priority: Minor
>>         Attachments: DERBY-3157.diff
>>
>>
>> The following statement fails with an SQLException. Adding whitespace =

>> or other characters at the end of the comment makes it pass. Adding=20
>> more whitespace at the beginning of the comment doesn't help.
PreparedStatement ps =3D c.prepareStatement("VALUES 1 -- x"); Exception =
in
thread "main" java.sql.SQLSyntaxErrorException: Lexical error at line 1,
column 14.  Encountered: <EOF> after : "".
>> 	at
org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown
Source)
>> 	at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
Source)
>> 	at
org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unk=
now
n Source)
>> 	at
org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknow=
n
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown =
Source)
>> 	at
org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown =
Source)
>> 	at org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(Unknown =
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(Unknown =
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedPreparedStatement40.<init>(Unknown =
Source)
>> 	at org.apache.derby.jdbc.Driver40.newEmbedPreparedStatement(Unknown
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown =
Source)
>> 	at
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown =
Source)
>> 	at comment.main(comment.java:5)
>> Caused by: java.sql.SQLException: Lexical error at line 1, column 14.
Encountered: <EOF> after : "".
>> 	at
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown
Source)
>> 	at
org.apache.derby.impl.jdbc.SQLExceptionFactory40.wrapArgsForTransportAcro=
ssD
RDA(Unknown Source)
>> 	... 14 more
>> Caused by: ERROR 42X02: Lexical error at line 1, column 14.  =
Encountered:
<EOF> after : "".
>> 	at
org.apache.derby.iapi.error.StandardException.newException(Unknown =
Source)
>> 	at
org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown =
Source)
>> 	at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown
Source)
>> 	at org.apache.derby.impl.sql.GenericStatement.prepare(Unknown
Source)
>> 	at
org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareIn=
ter
nalStatement(Unknown Source)
>> 	... 8 more
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

--=20
Dag H. Wanvik
Sun Microsystems, Database Technology Group (DBTG)
Haakon VII gt. 7b, N-7485 Trondheim, Norway
Tel: x43496/+47 73842196, Fax:  +47 73842101