From derby-dev-return-50594-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Mon Nov 05 15:44:48 2007 Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 18747 invoked from network); 5 Nov 2007 15:44:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Nov 2007 15:44:48 -0000 Received: (qmail 46372 invoked by uid 500); 5 Nov 2007 15:42:59 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 46342 invoked by uid 500); 5 Nov 2007 15:42:59 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 46333 invoked by uid 99); 5 Nov 2007 15:42:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Nov 2007 07:42:59 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Nov 2007 15:43:10 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 95DBF71420D for ; Mon, 5 Nov 2007 07:42:50 -0800 (PST) Message-ID: <23940968.1194277370609.JavaMail.jira@brutus> Date: Mon, 5 Nov 2007 07:42:50 -0800 (PST) From: "Knut Anders Hatlen (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3156) Convert testing of derby error stream to JUnit In-Reply-To: <9980301.1193645751263.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3156?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540205 ]=20 Knut Anders Hatlen commented on DERBY-3156: ------------------------------------------- Hi Vemund, The patch generally looks good. A couple of comments/questions: 1) Do the original tests run with the client driver? It seems to me they do= n't, so I think it's okay to run them only in embedded mode. 2) I think it would be good to null out the fields when the test has comple= ted (in tearDown()) so that the objects they reference can be garbage colle= cted. 3) Instead of using File.deleteOnExit(), perhaps it's cleaner to delete the= files explicitly in tearDown()? Seems that it would also remove the need f= or the runNo field. 4) I'm wondering if this code + new File(getSystemProperty("derby.system.home") +"foo",=20 + makeStreamFilename("file")).getCanonicalPath()); // erroneou= s path would be more robust if it was written as new File(new File(getSystemProperty("derby.system.home"), "foo"), ...) As it is now, I think it depends on derby.system.home ending with the path = separator character. > Convert testing of derby error stream to JUnit > ---------------------------------------------- > > Key: DERBY-3156 > URL: https://issues.apache.org/jira/browse/DERBY-3156 > Project: Derby > Issue Type: Test > Components: Test > Reporter: Vemund =C3=98stgaard > Assignee: Vemund =C3=98stgaard > Priority: Minor > Attachments: 3156-diff, 3156-diff.stat, 3156-diffv2, 3156-diffv2.= stat > > > Convert the tests that are related to derby error stream properties and f= unctionality. > Seems to be these two tests: > lang/logStream.java=20 > lang/errorStream.java --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.