db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dag.Wan...@Sun.COM (Dag H. Wanvik)
Subject Re: [jira] Reopened: (DERBY-3211) Convert derbynet/NSinSameJVM.java to junit
Date Sun, 25 Nov 2007 22:41:18 GMT
"Knut Anders Hatlen (JIRA)" <jira@apache.org> writes:

>      [ https://issues.apache.org/jira/browse/DERBY-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Knut Anders Hatlen reopened DERBY-3211:
> ---------------------------------------
>
>
> Reopening the issue since there are some remaining problems:
>
> 1) Dan's comment about try/catch/println is not addressed. As the test is written now,
JUnit won't ever notice if the test fails, since all exceptions are swallowed.
>
> 2) I don't think the port number and host name should be hard coded
> in the test. Instead of "localhost", TestConfiguration.getHostName()
> should be used. Also, I think we need to add a method to
> TestConfiguration called getAlternativePort() or something, instead
> of hard coding the port number 20000 in the test. The point of
> centralizing the allocation of port numbers in TestConfiguration, is
> to enable people to run multiple JUnit tests in parallel on the same
> machine without conflicting with each other (there was an effort
> some time ago to achieve this, I don't remember how far they

I did some work on this, and at that point in time, no tests used any
port except the one found in TestConfiguration. I verified this by
tracing the server code opening the port. This state of things may
have deteriorated since, though.

Thanks,
Dag


Mime
View raw message