db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vemund Østgaard (JIRA) <j...@apache.org>
Subject [jira] Updated: (DERBY-3156) Convert testing of derby error stream to JUnit
Date Tue, 06 Nov 2007 15:07:50 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vemund Østgaard updated DERBY-3156:
-----------------------------------

    Attachment: 3156-diffv3.stat
                3156-diffv3

Thank you for the comments Knut, I've uploaded a v3 of the patch that addresses your comments
as follows:

1. I don't think it has run with the client driver before, it would have failed with the same
bug that I hit.

2. The fields are now nulled out in tearDown().

3. The files are now deleted directly in tearDown(). I haven't removed the use of the runNo
field, somehow it gives me a warm feeling knowing that the filenames used are unique, so that
the chance of one of the tests passing by accident is less (The correct setting for the property
carries over from a previous execution or the file wasn't deleted and was accidentally there
with the correct name, etc.). So, I've left the use of the runNo field as it was.

4. I've changed the code as you suggest, I agree it is more predictable. 



> Convert testing of derby error stream to JUnit
> ----------------------------------------------
>
>                 Key: DERBY-3156
>                 URL: https://issues.apache.org/jira/browse/DERBY-3156
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Vemund Østgaard
>            Assignee: Vemund Østgaard
>            Priority: Minor
>         Attachments: 3156-diff, 3156-diff.stat, 3156-diffv2, 3156-diffv2.stat, 3156-diffv3,
3156-diffv3.stat
>
>
> Convert the tests that are related to derby error stream properties and functionality.
> Seems to be these two tests:
> lang/logStream.java 
> lang/errorStream.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message