db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Zaun <Martin.Z...@Sun.COM>
Subject copy&paste bug in BaseMonitor?
Date Fri, 30 Nov 2007 22:01:54 GMT

Hi,
a particular line of code
   java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java:1086
very much looks like a copy&paste bug to me:

     private Vector getImplementations(Properties moduleList, boolean actualModuleList) {
             ...
             if (key.startsWith(Property.MODULE_PREFIX)) {
                 tag = key.substring(Property.MODULE_PREFIX.length());
             } else if (key.startsWith(Property.SUB_SUB_PROTOCOL_PREFIX)) {
                 tag = key.substring(Property.MODULE_PREFIX.length());
                                              ^^^^^^^^^^^^^
             } ...

I guess MODULE_PREFIX was meant to be replaced with SUB_SUB_PROTOCOL_PREFIX.

Comments?

Regards,
Martin

Mime
View raw message