db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3191) SQL roles: add upgrade support
Date Tue, 20 Nov 2007 16:02:43 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543927
] 

Rick Hillegas commented on DERBY-3191:
--------------------------------------

Thanks for the patch, Dag. Sorry to let it languish on the queue so long. It looks good to
me. I have one stylistic comment which you can dismiss as a religious quirk: The inner class
AdditionalDb has a field called "noShutdown". The variable is referenced once just by itself
and once with a ! prepended. I  always stumble over double negatives like "not noShutdown".
Regards-Rick

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: DERBY-3191.diff, DERBY-3191.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message