db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ole Solberg (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1734) Simplify building of SystemColumn array in CatalogRowFactory implementations.
Date Wed, 21 Nov 2007 08:11:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544189
] 

Ole Solberg commented on DERBY-1734:
------------------------------------

2007-11-20 nightlies: 10.3 regression tests fails in lang/CompressTable.sql. 

Probably caused by r596490 which includes r564792:

We saw the same with r564792 on trunk. This was fixed by
r566353 | djd | 2007-08-15 23:45:33 +0200 (Wed, 15 Aug 2007) | 1 line - Fix compressTable
master file.

See e.g. http://dbtg.thresher.com/derby/test/10.3Branch/jvm1.6/testing/Limited/testSummary-596747.html
or http://dbtg.thresher.com/derby/test/stats_today.html as of 2007-11-21 (the "-5001" entry).



> Simplify building of SystemColumn array in CatalogRowFactory  implementations.
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-1734
>                 URL: https://issues.apache.org/jira/browse/DERBY-1734
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Daniel John Debrunner
>            Assignee: Daniel John Debrunner
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>
> The implementations of CatalogRowFactory.buildColumnList() can be simplified in a number
of ways:
>   1) precision & scale are always passed in as zero and can be removed
>    2) adding static factory methods to SystemColumnImpl would ease the building of the
arrays by not requiring the additional redundant arguments the constructor call forces today,
e.g. max length i snot required to create an INTEGER column.
>     3) The column's position is not required to be stored in the SytstemColumn class,
it's defined by the position in the array
> 4) arrays can be built using
>           new SystemColumn[] { ... }
>      syntax instead of the existing
>             columnList[0] = ...
>             columnList[1] = ...
>       or
>             columnList[index++] = ...
>             columnList[index++] = ...
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message