Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 57306 invoked from network); 8 Oct 2007 12:23:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Oct 2007 12:23:15 -0000 Received: (qmail 57491 invoked by uid 500); 8 Oct 2007 12:23:03 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 57467 invoked by uid 500); 8 Oct 2007 12:23:03 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 57458 invoked by uid 99); 8 Oct 2007 12:23:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2007 05:23:02 -0700 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [192.18.6.24] (HELO gmp-eb-mail-2.sun.com) (192.18.6.24) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2007 12:23:03 +0000 Received: from fe-emea-09.sun.com (gmp-eb-lb-2-fe3.eu.sun.com [192.18.6.12]) by gmp-eb-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l98CMVlL009184 for ; Mon, 8 Oct 2007 12:22:31 GMT Received: from conversion-daemon.fe-emea-09.sun.com by fe-emea-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JPL00G01DWXSU00@fe-emea-09.sun.com> (original mail from Kristian.Waagan@Sun.COM) for derby-dev@db.apache.org; Mon, 08 Oct 2007 13:22:31 +0100 (BST) Received: from [129.159.112.188] by fe-emea-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JPL003FDEDDJF70@fe-emea-09.sun.com> for derby-dev@db.apache.org; Mon, 08 Oct 2007 13:22:25 +0100 (BST) Date: Mon, 08 Oct 2007 14:22:22 +0200 From: Kristian Waagan Subject: Re: [jira] Updated: (DERBY-2824) Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader In-reply-to: <46EEAFB8.2030406@sbcglobal.net> Sender: Kristian.Waagan@Sun.COM To: derby-dev@db.apache.org Message-id: <470A20FE.8030108@Sun.com> Organization: Sun Microsystems Inc. MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=UTF-8 Content-transfer-encoding: 7BIT References: <16509066.1190037663880.JavaMail.jira@brutus> <46EEAFB8.2030406@sbcglobal.net> User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; no-NO; rv:1.8.1.3) Gecko/20070419 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 X-Virus-Checked: Checked by ClamAV on apache.org Kathey Marsden wrote: > Kristian Waagan (JIRA) wrote: >> >>> Improve error reporting, fix whitespace/formatting issues and replace >>> tabs in UTF8Reader >>> > I think ideally it is good to keep whitespace/formatting diffs as a > separate checkin. It makes it clearer which are code changes and which > are not. Is it possible to have two checkins, one for the > format/whitespace changes and another for the actual code changes? Hello Kathey, Sorry, but I'm a bit behind on the mail and didn't notice this one before today. A swifter way to reach me would be to comment on the issue itself through Jira. I do normally pay attention to all mail, but sometimes the volume of messages gets too high so I miss the important ones... I separated the various fixes from the start, and the issue consists of the following patches: derby-2824-1a-tabs_to_spaces.diff derby-2824-2a-whitespace_changes.diff derby-2824-3b-improved_error_reporting.diff derby-2824-4a-javadoc.diff There will be no further work on the issue, and I have closed it. regards, -- Kristian > > > Kathey > >