db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Should BrokeredStatement.isClosed() be public?
Date Tue, 09 Oct 2007 19:37:12 GMT
BrokeredStatement implements an isClosed() method with protected access. 
That method is overridden with a public isClosed() in 
BrokeredStatement40.  Testing with a new 1.6 jdk this leads to a 
IllegalAccessError when  stmt.isClosed() is accessed.  Should 
BrokeredStatement.isClosed() be public?  This patch seems to make the 
error go away.  If noone objects, I'll run tests and commit.



+++ java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement.java       
(working copy)
@@ -566,7 +566,7 @@
      * <code>false</code> otherwise
      * @exception SQLException not-implemented exception
-    protected boolean isClosed() throws SQLException {
+    public boolean isClosed() throws SQLException {
         // Not implemented since we cannot forward the call to a JDBC
         // 4.0 method from this class. This dummy implementation is
         // provided here so that checkIfClosed() can be implemented

View raw message