db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3064) Implement the LogShipper that will enable the shipping of Log records from the master to the slave
Date Mon, 29 Oct 2007 14:10:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538504
] 

Knut Anders Hatlen commented on DERBY-3064:
-------------------------------------------

Do we need try/catch here? (in MasterController.startMaster)

+        try {
+            logFactory.startReplicationMasterRole(this);
+        } catch (StandardException se) {
+            Monitor.logMessage(REPLICATION_MESSAGE_HEADER + 
+                    "Exception occurred while trying to start replication" +
+                    " Master role.");
+            printErrorStack(se);
+            throw StandardException.newException
+                    (SQLState.REPLICATION_UNEXPECTED_EXCEPTION, se);
+        }

The method is declared as "throws StandardException", so there's no need to wrap se, I think.
And exceptions are automatically logged in accordance with derby.stream.error.logSeverityLevel
anyway, aren't they? If the user has requested no error logging, I'm not sure if we should
ignore that request. (If the user is never going to see the exception, I think it's a good
idea to log it, but in startMaster() the exception will propagate out to the user, if I understand
correctly.)

> Implement the LogShipper that will enable the shipping of Log records from the master
to the slave
> --------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3064
>                 URL: https://issues.apache.org/jira/browse/DERBY-3064
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: LogShipperImpl_v1.diff, LogShipperImpl_v1.stat, LogShipperImpl_v2.diff,
LogShipperImpl_v2.stat, LogShipperImpl_v3.diff, LogShipperImpl_v3.stat, LogShipperImpl_v4.diff,
LogShipperImpl_v4.stat, LogShipperImpl_v5.diff, LogShipperImpl_v5.stat, LogShipperIntegration_v1.diff,
LogShipperIntegration_v1.stat, LogShipperIntegration_v2.diff, LogShipperIntegration_v2.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message