db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1387) Add JMX extensions to Derby
Date Fri, 05 Oct 2007 19:49:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532760

Rick Hillegas commented on DERBY-1387:

Thanks for the patch, Bernt. I have a couple comments:


Bean method names: Maybe the accessor  method names could include all
of the legs of the property names (except for the leading "derby").
So, for instance, getMinimumRecordSize() would become
getStorageMinimumRecordSize(). Then getMonitor() would become
getLocksMonitor() and make a little more sense. This provides a
regular pattern for others to follow when more properties are added
and I think, in the long run, will result in less confusion and fewer
name collisions.

What are our internationalization expectations here? I see that
exceptions have hard-coded English strings in them.

Couldn't we use the constants in Property.java rather than hard-coded
property strings? If the problem is that Property.java doesn't live in
the correct jar file, then this can be solved the way we tackled this
problem for SQLState.java.


I think that user management method names should indicate that we are
configuring users for the BUILTIN mode. Could we have a method for
deleting a BUILTIN user too? I think that the user management methods
should raise an exception if BUILTIN authentication hasn't been
enabled--I think it would be confusing to be able to call these
methods if they aren't really going to have an effect.

Does anything prevent more than one client from manipulating a
database at the same time? Should we build some sort of lock to
control this?


The header comment says that this class uses callbacks to
NetworkServerControlImpl rather than calling
NetworkServerControl. That makes me wonder, why?

> Add JMX extensions to Derby
> ---------------------------
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: Services
>            Reporter: Sanket Sharma
>            Assignee: Bernt M. Johnsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, DERBY-1387-2.stat,
DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, DERBY-1387-4.stat, DERBY-1387-5.diff,
DERBY-1387-5.stat, DERBY-1387-6.zip, derbyjmx.patch, jmx.diff, jmx.stat, jmxFuncspec.html,
Requirements for JMX Updated.html, Requirements for JMX.html, Requirements for JMX.zip
> This is a draft requirement specification for adding monitoring and management extensions
to Apache Derby using JMX. The requirements document has been uploaded on JIRA as well as
the Derby Wiki page at http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature list in particular)
and add their own rating to features by adding a coloumn to the table.
> Comments are welcome.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message