db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jørgen Løland (JIRA) <j...@apache.org>
Subject [jira] Assigned: (DERBY-974) ClientDriver can lose some connection properties
Date Tue, 16 Oct 2007 08:02:50 GMT

     [ https://issues.apache.org/jira/browse/DERBY-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jørgen Løland reassigned DERBY-974:
-----------------------------------

    Assignee: Jørgen Løland

The bug is still present in the current trunk (verified by println's in ClientDriver), and
the fix is simple. However, I cannot figure out how to write a test for this. I need a method
that returns the values in the Properties object of the connection. The method java.sql.Connect#getClientInfo(String
name) would probably do the trick, but that method is introduced in Java 1.6. However, I don't
think the lack of a regression test should block the fix.

I'll upload a patch in a few days. If I get a hint for how to write a test before that, I'll
be glad to add that as well.

> ClientDriver can lose some connection properties
> ------------------------------------------------
>
>                 Key: DERBY-974
>                 URL: https://issues.apache.org/jira/browse/DERBY-974
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.1.2.1, 10.1.3.1
>         Environment: Linux, Sun JRE 1.5
>            Reporter: Michael Hackett
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: ClientDriver.java-diff, PropertiesTest.java
>
>
> Internally, the ClientDriver class's appendDatabaseAttributes() method uses keys() on
the connection properties to get a list of the property names. However, this misses any properties
in the default set. The correct method for a Properties object is propertyNames(). This will
return the same type of object as keys(), but will include all properties.
> (It is unfortunate that Sun chose to make Properties a subclass of Hashtable, instead
of giving Properties a Hashtable, as the former exposes too much implementation.)
> The fix is to simply replace calls to keys() on all Property objects to use propertyNames().
A quick search revealed that this is not the only place in the code base where this is done,
so a more thorough scan should be made.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message