db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2109) System privileges
Date Mon, 08 Oct 2007 15:22:51 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533146
] 

Rick Hillegas commented on DERBY-2109:
--------------------------------------

Thanks for the combined patch, Martin. This is really beautiful code showcasing some nice
design patterns. I have a couple comments:

1) EmbeddConnection and InternalDriver:

The construction of the Subject is a bit involved and this code is
duplicated for the createDB and shutdownEngine checks. I think it
would be better if this construction of the Subject were abstracted
out into a shareable piece of code.

2) NetworkServerControlImpl:

I think that there is no need to invent the concept of a default
password for the APP account. I think it would be better to default
passwordArg to "" or null.

init() and checkShutdownPrivileges()

I notice that init() always sets the user and password properties but
checkShutdownPrivileges() only sets them if the are not null. What is
the reason for this asymmetry?

3) server.policy

I would expand the comment to punch up the message that these are
broad privileges which we encourage the user to narrow. Also, you will
want to make corresponding changes to
java/drda/org/apache/derby/drda/template.policy

4) derby_tests.policy

As a bit of defensive coding, you may want to make corresponding
changes to the other policy files used by the regression tests.

5) SystemPrivilegesPermissionTest

I would convert the System.out.println() diagnostics to println()
calls. That way you will see this output when you turn on debugging,
but the printout won't show up for ordinary regression test runs.

6) I think that 05 and 06 must be committed together. 05 wires in the
references which are necessary to pull the new permission and
principal classes into the jar files. Without these references, the
new regression tests will fail if run against jar files.




> System privileges
> -----------------
>
>                 Key: DERBY-2109
>                 URL: https://issues.apache.org/jira/browse/DERBY-2109
>             Project: Derby
>          Issue Type: New Feature
>          Components: Security
>    Affects Versions: 10.3.1.4
>            Reporter: Rick Hillegas
>            Assignee: Martin Zaun
>         Attachments: DERBY-2109-02.diff, DERBY-2109-02.stat, derby-2109-03-javadoc-see-tags.diff,
DERBY-2109-04.diff, DERBY-2109-04.stat, DERBY-2109-05.diff, DERBY-2109-05.stat, DERBY-2109-05and06.diff,
DERBY-2109-05and06.stat, DERBY-2109-06.diff, DERBY-2109-06.stat, SystemPrivilegesTestCases.html,
systemPrivs.html, systemPrivs.html, systemPrivs.html, systemPrivs.html
>
>
> Add mechanisms for controlling system-level privileges in Derby. See the related email
discussion at http://article.gmane.org/gmane.comp.apache.db.derby.devel/33151.
> The 10.2 GRANT/REVOKE work was a big step forward in making Derby more  secure in a client/server
configuration. I'd like to plug more client/server security holes in 10.3. In particular,
I'd like to focus on  authorization issues which the ANSI spec doesn't address.
> Here are the important issues which came out of the email discussion.
> Missing privileges that are above the level of a single database:
> - Create Database
> - Shutdown all databases
> - Shutdown System
> Missing privileges specific to a particular database:
> - Shutdown that Database
> - Encrypt that database
> - Upgrade database
> - Create (in that Database) Java Plugins (currently  Functions/Procedures, but someday
Aggregates and VTIs)
> Note that 10.2 gave us GRANT/REVOKE control over the following  database-specific issues,
via granting execute privilege to system  procedures:
> Jar Handling
> Backup Routines
> Admin Routines
> Import/Export
> Property Handling
> Check Table
> In addition, since 10.0, the privilege of connecting to a database has been controlled
by two properties (derby.database.fullAccessUsers and derby.database.defaultConnectionMode)
as described in the security section of the Developer's Guide (see http://db.apache.org/derby/docs/10.2/devguide/cdevcsecure865818.html).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message