db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3021) Replication: Add a ReplicationSlave controller that will manage replication on the slave side
Date Fri, 14 Sep 2007 09:02:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527416

Øystein Grøvlen commented on DERBY-3021:

Code looks good.  I have just a few minor comments, all on wording,
but I think at least the javadoc errors need to be fixed before I can
commit this patch:

1. SlaveController#boot:  

   I assume you mean 'new NetworkReceive()'

2. SlaveController#failover, javadoc:

   a) "operations from transactions where the commit log record has
      not been received from the master will be removed" sounds a bit
      strange to me.  I suggest either "... will be undone" or
      "... will not be reflected".

   b) References to MasterFactory and MasterController will not be
      resolved since they are not it the same package.

3. BasicDatabase#boot, comment:

   "Make sure it is not connected to by other clients".  I think it
   would be clearer if you said: "Make sure other clients are not able
   to connect"

4. SlaveFactory#failover, javadoc:

   See 2 b)

5. messages.xml:

   I suggest:  "Connection refused to database ..."

> Replication: Add a ReplicationSlave controller that will manage replication on the slave
> ---------------------------------------------------------------------------------------------
>                 Key: DERBY-3021
>                 URL: https://issues.apache.org/jira/browse/DERBY-3021
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions:
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>         Attachments: derby-3021-1.diff, derby-3021-1.stat
> The replication slave role includes many tasks:
> * set up a network connection with the master
> * receive chunks of log from the master, and parse these into individual log records
> * append log records to the local log file
> * make sure that the recovery process is not allowed to access the logfile we are currently
writing to
> * etc
> This issue is for adding a controller that will start/stop/initiate all services needed
for the replication slave role.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message