db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-2977) Replication: Add a ReplicationMaster controller that will manage replication on the master side
Date Mon, 03 Sep 2007 11:11:19 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524499
] 

Øystein Grøvlen commented on DERBY-2977:
----------------------------------------

I think this patch looks very good.  Most of my comments are minor:

1. Why do you need to expose LogToFile#logBufferSize outside the
   class?  The Logger used by transactions handles the buffer size
   dynamically, why cannot this be done in this case, too?

2. MasterFactory#flushedTo:  The Javadoc should say something
   about why this method is needed and when it will be called.

3. I think it would be good if it is were more clear from the
   MasterController code, which methods were implementation of which
   interface.  E.g., have separate sections of the file for each of
   the interfaces with a heading in a comment.

4. MasterController#canSupport: The javadoc for the return value
   should say something about what it means, not just its
   current implementation.

5. ReadOnly:  The new import does not seem necessary.

6. MasterFactory javadoc says "This is an implementation ...", but it
   is not.  It is the interface.  MasterController is the
   implementation.  I also think the note about being far from
   complete belongs in the class and not the interface.  (There is
   also a missing "to" in the second sentence of the javadoc.)


> Replication: Add a ReplicationMaster controller that will manage replication on the master
side
> -----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2977
>                 URL: https://issues.apache.org/jira/browse/DERBY-2977
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>         Attachments: derby_2977_1.diff, derby_2977_1.stat
>
>
> The replication master role includes many tasks:
> * set up a network connection to the slave
> * sending the database to the slave before starting replication
> * make sure that log records are appended to the network buffer, and that the log is
later sent to the slave
> * etc
> This issue is for adding a controller that will start/stop/initiate all services needed
for the replication master role.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message