db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3041) Merge the separate JDBC 2.0 and JDBC 3.0 implementations in the ij code (Main/Main14 and utilMain/utilMain14)
Date Sun, 02 Sep 2007 15:33:19 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524344
] 

Knut Anders Hatlen commented on DERBY-3041:
-------------------------------------------

utilMain/utilMain14 have workarounds for problems in WebLogic 4.5 (AbstractMethodError because
JDBC 2.0 was not implemented). Most of the workarounds for this problem were removed in this
commit:

------------------------------------------------------------------------
r426887 | djd | 2006-07-30 16:40:08 +0200 (su, 30 jul 2006) | 1 line

Minor cleanup in ij code, make methods non-public and remove an un-required method.
------------------------------------------------------------------------

I assume it is OK to remove the workarounds that were forgotten in the previous clean-up.
If WebLogic 4.5 didn't implement JDBC 2.0, I doubt that it is able to load classes compiled
for Java 1.4 anyway.

> Merge the separate JDBC 2.0 and JDBC 3.0 implementations in the ij code (Main/Main14
and utilMain/utilMain14)
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3041
>                 URL: https://issues.apache.org/jira/browse/DERBY-3041
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3041-1.diff, d3041-1.stat
>
>
> The classes utilMain and utilMain14 contain utility methods for manipulating the holdability
of a connection or a statement. There is one implementation for JDBC 2.0 JVMs and one implementation
for JDBC 3.0 JVMs. Since Derby now only supports JVMs which support JDBC 3.0 (or JSR-169 which
is a subset of JDBC 3.0), we could move code from utilMain14 to utilMain and delete utilMain14.
The class Main14 behaves identically to the class Main, except that it returns utilMain14
instances, so once the utilMain14 class is removed, Main14 can be removed as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message