db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3064) Implement the LogShipper that will enable the shipping of Log records from the master to the slave
Date Wed, 26 Sep 2007 11:31:53 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530420
] 

Øystein Grøvlen commented on DERBY-3064:
----------------------------------------

V.Narayanan (JIRA) wrote:
>> 4. Why are exceptions from shipALogChunk handled differently by run()
>>   and forceFlush()? Maybe you could let shipALogChunk handle the
>>   exceptions instead so you do not have to do it in two places? 
> 
> * It is not possible to throw exceptions from the run method, hence
>   I throw it as RuntimeExceptions.

AFAIK, throwing an unchecked exception from the run method, will just
cause the thread to stop, and the exception will not be seen by other
threads.  Hence, a thread should try to deal with its own exceptions,
and only throw unchecked exceptions if there is no way to recover from
the failure.  

...

> * I thought about handling the exceptions in shipALogChunk itself,
>   but we need some way of informing the MasterController that the
>   shipping has failed. We need the MasterController to be informed
>   of the exception.
> 
>   Handling the exceptions inside shipALogChunk would muffle the
>   exceptions inside this method.
> 
> The above three considerations were what forced me to go in for the
> heterogeneity in handling the exceptions between the two methods.

I understand.  Makes sense.  

Maybe there is a need for the MasterController to provide a method to
be called by the log shipping thread to inform it when errors occurs.


> Implement the LogShipper that will enable the shipping of Log records from the master
to the slave
> --------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3064
>                 URL: https://issues.apache.org/jira/browse/DERBY-3064
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: LogShipperImpl_v1.diff, LogShipperImpl_v1.stat, LogShipperImpl_v2.diff,
LogShipperImpl_v2.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message