db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2921) Replication: Add a network service that connects the master and slave Derby instances
Date Thu, 20 Sep 2007 06:53:31 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

V.Narayanan updated DERBY-2921:

    Attachment: Replication_Network_v9.stat

Thank you for the comments and reviews Oystein. I have addressed all the issues pointed out
by you.

For the following

>I would like an explanation for why writeMessage does reset()
>and flush(). 

I had earlier added these methods for the following reason

reset() - to ensure that any previously existing data is deleted before a
              new replication message is sent. Since flush() would send all the
              data from a stream the existing of previous data in a stream would  
              mean a wrong data is present. Hence I thought reset() would take
              care of this.

              But I think this would be unnecessary since this situation can 
              happen only if there is an error in the previous transmission and
              tcp should throw an error in this situation

flush() - I had added to ensure that all the data is sent from the stream 
             amd have added a comment for the same.

In addition to this I have also fixed some more comments and javadoc
that I found could be improved when I did a scan on the patch.

I am running tests on this patch and shall revert back with results as
soon as the tests finish.

Thanks once again for the detailed reviews and comments.

> Replication: Add a network service that connects the master and slave Derby instances
> -------------------------------------------------------------------------------------
>                 Key: DERBY-2921
>                 URL: https://issues.apache.org/jira/browse/DERBY-2921
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions:
>            Reporter: Jørgen Løland
>            Assignee: V.Narayanan
>         Attachments: Replication_Network_expln_v6.txt, Replication_Network_v1.diff, Replication_Network_v1.stat,
Replication_Network_v2.diff, Replication_Network_v2.stat, Replication_Network_v3.diff, Replication_Network_v3.stat,
Replication_Network_v4.diff, Replication_Network_v4.stat, Replication_Network_v5.diff, Replication_Network_v5.stat,
Replication_Network_v6.diff, Replication_Network_v6.stat, Replication_Network_v7.diff, Replication_Network_v7.stat,
Replication_Network_v8.diff, Replication_Network_v8.stat, Replication_Network_v9.diff, Replication_Network_v9.stat
> A network connection is required between the master and slave Derby instances of a replicated
database. The connection will be used to send many kinds of messages, including:
> * log records
> * the database (when replication is started)
> * master -> slave commands (like "stop replication")

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message