db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-2921) Replication: Add a network service that connects the master and slave Derby instances
Date Wed, 19 Sep 2007 10:08:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528723
] 

Øystein Grøvlen commented on DERBY-2921:
----------------------------------------

Thanks for the new patch Narayanan, the changes look good.  I have a
few minor comments that I did not detect the previous time around:

9. SlaveAddress: Why since it is the address that will be returned,
   why not store the address instead of the hostname?

10. SocketConnection: 

    a) socket could be local to the constructor since it is not used
       in other methods.

    b) I would like an explanation for why writeMessage does reset()
       and flush().
   
    c) I suggest to refer all references to replication messages in
       comments and use message objects instead.

11. ReplicationMessageTransmit#sendInitiatorAndReceiveAck:  The cast
    to ReplicationMessage is redundant.

12. The added files no longer end with a newline.


> Replication: Add a network service that connects the master and slave Derby instances
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-2921
>                 URL: https://issues.apache.org/jira/browse/DERBY-2921
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: V.Narayanan
>         Attachments: Replication_Network_expln_v6.txt, Replication_Network_v1.diff, Replication_Network_v1.stat,
Replication_Network_v2.diff, Replication_Network_v2.stat, Replication_Network_v3.diff, Replication_Network_v3.stat,
Replication_Network_v4.diff, Replication_Network_v4.stat, Replication_Network_v5.diff, Replication_Network_v5.stat,
Replication_Network_v6.diff, Replication_Network_v6.stat, Replication_Network_v7.diff, Replication_Network_v7.stat,
Replication_Network_v8.diff, Replication_Network_v8.stat
>
>
> A network connection is required between the master and slave Derby instances of a replicated
database. The connection will be used to send many kinds of messages, including:
> * log records
> * the database (when replication is started)
> * master -> slave commands (like "stop replication")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message