Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <15169082.1188473551982.JavaMail.jira@brutus>
Date: Thu, 30 Aug 2007 04:32:31 -0700 (PDT)
From: =?utf-8?Q?=C3=98ystein_Gr=C3=B8vlen_=28JIRA=29?= <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
 for interacting with the replication functionality
In-Reply-To: <32940830.1184843764504.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/DERBY-2954?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523827 ]=20

=C3=98ystein Gr=C3=B8vlen commented on DERBY-2954:
----------------------------------------

Thank you for addressing my comments Narayanan.  The patch looks very
good.  I have tested that it fixes the issues I raised.  I have only some m=
inor nits:

1. replicationdbSync can be removed since it is no longer used.

2. The indentation and the way the if statement is broken into lines
   makes the new code in findCommand() a bit hard to read.
   I suggest you indent the wrapped lines of the if statement, and put each=
 argument
  on a separate line.

If nobody beats me to it, I will commit this patch when I get the
necessary powers to do so.


> Add commands to NetworkServerControl for interacting with the replication=
 functionality
> -------------------------------------------------------------------------=
--------------
>
>                 Key: DERBY-2954
>                 URL: https://issues.apache.org/jira/browse/DERBY-2954
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.4.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: NetworkServerControlCmds_v1.diff, NetworkServerContr=
olCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_=
v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat
>
>


--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.