db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3004) Get rid of the finalizer in EmbedResultSet
Date Tue, 14 Aug 2007 07:53:30 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519614
] 

Knut Anders Hatlen commented on DERBY-3004:
-------------------------------------------

Daniel John Debrunner commented (on DERBY-1876):

> I wonder if it's possible to move the finalizer logic to
> EmbedStatement. Since a ResultSet will always be referenced by its
> Statement then we only need to close the ResultSet when it's
> statement is finalized. Then EmbedResultSet would not need a
> finalizer method.

I think this is correct. I'll take a look at it and see if I can fix
it. EmbedPreparedStatement already has a finalize method which
probably can be pushed into EmbedStatement.

> Get rid of the finalizer in EmbedResultSet
> ------------------------------------------
>
>                 Key: DERBY-3004
>                 URL: https://issues.apache.org/jira/browse/DERBY-3004
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Performance
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>
> Finalizers make object allocation and garbage collection more expensive and should be
avoided for object types that are frequently allocated. EmbedResultSet has a finalize() method
and is frequently allocated for many types of load. The following comment was posted on DERBY-1876:
> By commenting out the finalize() method in EmbedResultSet, the time to run the test on
my laptop is reduced from ~3 seconds to ~1.3 seconds (OpenSolaris, Sun Java SE 6). Since the
finalizer is a no-op if the activation isn't single-use, I think we should investigate whether
there are ways to avoid this cost for ResultSets that don't need the finalizer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message