db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2999) convert lang/lockTable.sql to Junit
Date Wed, 22 Aug 2007 13:58:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521788

Kristian Waagan commented on DERBY-2999:

Hello Ravinder,

I had a look at the patch, and in my opinion it is not quite ready for commit.

My initial comments:
 1) The drop table statements in the setUp method fails.
 2) After fixing 1, the test takes over 300 seconds to complete. Is this what you intended?
 3) Does the new test actually test/verify the same things as the old one?
 4) A mix of tabs and spaces are used for indentation.

A nit, but don't you think it would be nicer with a blank line between methods?
I can have another look at the test when the initial comments are addressed.

Thanks for working on the tests :)

> convert lang/lockTable.sql to Junit
> -----------------------------------
>                 Key: DERBY-2999
>                 URL: https://issues.apache.org/jira/browse/DERBY-2999
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions:
>            Reporter: Ravinder Reddy
>            Assignee: Ravinder Reddy
>         Attachments: DERBY-2999.diff-v1, STATUS-2999-v1

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message