db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-2954) Add commands to NetworkServerControl for interacting with the replication functionality
Date Thu, 30 Aug 2007 11:32:31 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523827
] 

Øystein Grøvlen commented on DERBY-2954:
----------------------------------------

Thank you for addressing my comments Narayanan.  The patch looks very
good.  I have tested that it fixes the issues I raised.  I have only some minor nits:

1. replicationdbSync can be removed since it is no longer used.

2. The indentation and the way the if statement is broken into lines
   makes the new code in findCommand() a bit hard to read.
   I suggest you indent the wrapped lines of the if statement, and put each argument
  on a separate line.

If nobody beats me to it, I will commit this patch when I get the
necessary powers to do so.


> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-2954
>                 URL: https://issues.apache.org/jira/browse/DERBY-2954
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.4.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat,
NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff,
NetworkServerControlCmds_v3.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message