db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jørgen Løland (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-2921) Replication: Add a network service that connects the master and slave Derby instances
Date Mon, 27 Aug 2007 08:03:30 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522947
] 

Jørgen Løland commented on DERBY-2921:
--------------------------------------

Hi Narayanan

Thanks for submitting the patch. It looks good for the most part, but I have a few nits:

1) The AccessController.doPrivileged lines have more than 80 chars, but I notice that you
have already tried to break this up by e.g. having "(Socket)" on a separate line (see line
483 in the v3 diff). Feel free to ignore this...

2) I wonder if defaulting to localhost is a good idea - replicating a db back to the same
host seems to be little worth. Maybe we should require the host to be specified? Further,
the defaultNetworkValues method in both transmitter and receiver sets both host and port to
default even if only one of these are not specified. 

3) I would add the following info to the javadoc somewhere, possibly in the class descriptions:
If the network connection is lost for some reason, both readExternal and writeExternal will
get an exception (IOException?). This means that neither of these methods will loop infinitely
if something is wrong with the connection.

4) The variable ReplicationMessage answer = null; in ReplicationMessageTransmit#send is not
used

> Replication: Add a network service that connects the master and slave Derby instances
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-2921
>                 URL: https://issues.apache.org/jira/browse/DERBY-2921
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: V.Narayanan
>         Attachments: Replication_Network_v1.diff, Replication_Network_v1.stat, Replication_Network_v2.diff,
Replication_Network_v2.stat, Replication_Network_v3.diff, Replication_Network_v3.stat
>
>
> A network connection is required between the master and slave Derby instances of a replicated
database. The connection will be used to send many kinds of messages, including:
> * log records
> * the database (when replication is started)
> * master -> slave commands (like "stop replication")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message