db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramin Moazeni" <rmoaz...@gmail.com>
Subject Re: [jira] Commented: (DERBY-2854) Convert jdbc4/TestResultSetMethods.java to JUnit
Date Mon, 09 Jul 2007 21:40:11 GMT
Hi Dan

Thanks for your review feedback. I changed the test
to use utility methods in creating statement objects. However,
there are cases where there is no utility method provided for
createStatement, prepareCall, etc
(e.g ceateStatement (int resultSetType, int resultSetConcurrency, int
resultSetHoldability) )

To resolve this issue, I can go ahead an add these methods to
BaseJDBCTestCase.java...any thought?

Please advise...

Thanks,
Ramin

On 7/6/07, Daniel John Debrunner (JIRA) <jira@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/DERBY-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510748
]
>
> Daniel John Debrunner commented on DERBY-2854:
> ----------------------------------------------
>
> The test could use the utility methods in most test fixtures to create statement objects.
>
> Replace
>
>  Statement s = conn.createStatement();
>
> with
>
>   Statement s = createStatement();
>
> e.g. in testGetHoldability().
>
> These objects will very soon be automatically closed at tearDown and make the test more
readable.
>
> > Convert jdbc4/TestResultSetMethods.java to JUnit
> > ------------------------------------------------
> >
> >                 Key: DERBY-2854
> >                 URL: https://issues.apache.org/jira/browse/DERBY-2854
> >             Project: Derby
> >          Issue Type: Task
> >    Affects Versions: 10.3.0.0
> >            Reporter: Ramin Moazeni
> >            Assignee: Ramin Moazeni
> >         Attachments: DERBY-2854v0.diff, DERBY-2854v0.stat, DERBY-2854v1.diff, DERBY-2854v1.stat
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
View raw message