db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-2936) Use java.nio.ByteBuffer for buffering in DDMWriter
Date Fri, 13 Jul 2007 12:26:04 GMT
Use java.nio.ByteBuffer for buffering in DDMWriter
--------------------------------------------------

                 Key: DERBY-2936
                 URL: https://issues.apache.org/jira/browse/DERBY-2936
             Project: Derby
          Issue Type: Improvement
          Components: Network Server
            Reporter: Knut Anders Hatlen
            Priority: Minor


org.apache.derby.impl.drda.DDMWriter uses a byte array as a buffer. Wrapping the array in
a java.nio.ByteBuffer has some advantages, for instance:

  - utility methods for encoding primitive types into the byte array could be used instead
of manually encoding the values
  - it allows us to encode strings directly into the buffer (using a CharsetEncoder) without
doing an expensive String.getBytes(String encoding) in an intermediate step

By using a utility class, the code becomes easier to maintain. Also, ByteBuffer allows us
to access the backing byte array without going through the ByteBuffer interface, so we still
have the possibility to modify the byte array directly in cases where that's more convenient.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message