db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2942) Convert jdbcapi/statementJdbc30.java to JUnit
Date Thu, 26 Jul 2007 20:50:03 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515857
] 

Kathey Marsden commented on DERBY-2942:
---------------------------------------

Ramin, do you mind if I make a couple of small changes before I check this in
1) Reformat the code to remove mixed tab/spaces.
2) Change the test cases so they run in both embedded and client. I think I did not make my
prior comment  clear.  
Essentially we will run all the test with both embedded and client and have
     } catch (SQLException ex) {
            assertFailedExecuteUpdate(ex);
        }


where  we have

 /**
     * Assert executeUpdate failed. There are different SQLStates for 
     * client and server.
     * 
     * @param ex
     */
    private void assertFailedExecuteUpdate(SQLException ex) {
        /*
         * DERBY-2943 -- execute() and executeUpdate() return different
         * SQLState in embedded and network client
         * 
         */
        if (usingDerbyNetClient()) {
            assertSQLState("0A000", ex);
        } else {
            assertSQLState("X0X0E", ex);
        }
    }

If you don't mind these changes, I'll go ahead and check in.

Kathey


> Convert jdbcapi/statementJdbc30.java to JUnit
> ---------------------------------------------
>
>                 Key: DERBY-2942
>                 URL: https://issues.apache.org/jira/browse/DERBY-2942
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Ramin Moazeni
>            Assignee: Ramin Moazeni
>         Attachments: DERBY-2942v0.diff, DERBY-2942v0.stat, DERBY-2942v1.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message