db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
Date Thu, 26 Jul 2007 21:36:04 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515880
] 

Kathey Marsden commented on DERBY-2900:
---------------------------------------

Thanks Ugo for converting these tests and sorry for the late review.  Below are some comments.

In General:

There is a mixture of tabs and space indentation in new files. Please change to all spaces.

Instead of 
while (rs.next()) {
			//System.out.println(rs.getString(1));
		}

use JDBC.assertFullResultSet or JDBC.assertSingleValueResultSet  to check the results.


Statements created with createStatement() or prepareStatement()  do not need to be closed.
They will be closed automatically.


It would be good to have javadoc comments for the methods.

For Bug5054 I think the contents of setUp can just be moved donw into the test method.  testBugBug5054
can be renamed with just one "Bug"


Thanks

Kathey


> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
>                 Key: DERBY-2900
>                 URL: https://issues.apache.org/jira/browse/DERBY-2900
>             Project: Derby
>          Issue Type: Test
>            Reporter: Ugo Matrangolo
>            Assignee: Ugo Matrangolo
>            Priority: Minor
>         Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message