db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2885) Wrong connection object used in EmbedConnection.clearLOBMapping()
Date Sun, 01 Jul 2007 15:22:04 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-2885:

    Attachment: lobmap2.diff

Attaching lobmap2.diff which contains some more cleanup of EmbedConnection.clearLOBMapping():
  1) Store the map in a local variable instead of calling getlobHMObj() a number of times.
  2) Replace two disjoint if statements with if/else-if + THROWASSERT if none of them matches.

All tests passed.

> Wrong connection object used in EmbedConnection.clearLOBMapping()
> -----------------------------------------------------------------
>                 Key: DERBY-2885
>                 URL: https://issues.apache.org/jira/browse/DERBY-2885
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC, Performance
>    Affects Versions:,,
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>             Fix For:,
>         Attachments: lobmap.diff, lobmap2.diff
> I think there are two bugs in EmbedConnection.clearLOBMapping():
>   1) It checks if lobHashMap is non-null, but it should have checked rootConnection.lobHashMap.
>   2) It calls getlobHMObj().clear() regardless of whether there is a HashMap. This creates
a HashMap object even though it's not needed, and all the subsequent transactions on that
connection have to perform cleanup on that object.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message