Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <2407479.1181905827306.JavaMail.jira@brutus>
Date: Fri, 15 Jun 2007 04:10:27 -0700 (PDT)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-2812) Assessing blob (when its linked to
 DVD stream, ie large blob) corrupts stream fetched prior to this access.
In-Reply-To: <30504327.1181755705914.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505154 ] 

Kristian Waagan commented on DERBY-2812:
----------------------------------------

I had a look at 'derby-2812v2.diff'. I also ran suites.All with Java 1.5, and it completed without failures.
As far as I can see, all my comments are additional improvements and nitpicks.

Comments/questions:
 1) Since AutoPositioningStream extends BinaryToRawStream, can we be sure a non-store stream is never passed in? What's the consequence if it happens? (i.e. will the length be set to undetermined, or will the RawToBinaryStream fail?) I do see there is an assert in EmbedBlob, I was just thinking in more general terms.
    If AutoPositioningStream is only supposed to work on top of a PositionedStoreStream, maybe it should enforce that? As far as I can tell, it is not able to support the intended functionality if the passed in stream is not a PositionedStoreStream.

 2) I think conChild, positionedStream and stream can be made final.
 
 3) Some typos in the constructor JavaDoc (and "operation" -> "operations" in the class JavaDoc).

 4) In skip, I don't think InputStream.skip is allowed to return < 0, and so the if (ret > 0) could be removed. It is not incorrect to have it, it might just be unnecessary.

 5) Some trailing spaces on three "empty" lines. 

> Assessing blob (when its linked to DVD stream, ie large blob) corrupts stream fetched prior to this access.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2812
>                 URL: https://issues.apache.org/jira/browse/DERBY-2812
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.2.2.0, 10.3.0.0
>            Reporter: Anurag Shekhar
>            Assignee: Anurag Shekhar
>         Attachments: derby-2812-testsuites.diff, derby-2812.diff, derby-2812v2.diff, Derby2806.java
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.