Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 29781 invoked from network); 15 Jun 2007 12:12:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jun 2007 12:12:49 -0000 Received: (qmail 70113 invoked by uid 500); 15 Jun 2007 12:12:51 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 69997 invoked by uid 500); 15 Jun 2007 12:12:51 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 69923 invoked by uid 99); 15 Jun 2007 12:12:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2007 05:12:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2007 05:12:47 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CC2DE71418F for ; Fri, 15 Jun 2007 05:12:26 -0700 (PDT) Message-ID: <1302922.1181909546834.JavaMail.jira@brutus> Date: Fri, 15 Jun 2007 05:12:26 -0700 (PDT) From: "Anurag Shekhar (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-2812) Assessing blob (when its linked to DVD stream, ie large blob) corrupts stream fetched prior to this access. In-Reply-To: <30504327.1181755705914.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anurag Shekhar updated DERBY-2812: ---------------------------------- Attachment: derby-2812v3.diff 1) Since AutoPositioningStream extends BinaryToRawStream, can we be sure a non-store stream is never passed in? What's the consequence if it happens? (i.e. will the length be set to undetermined, or will the RawToBinaryStream fail?) I do see there is an assert in EmbedBlob, I was In this patch derby-2812v3.diff i have addressed Kristian's comments 1. Enforcing PositionedStoreStream in AutoPositioningStream using SanityMagaer.assert 2) I think conChild, positionedStream and stream can be made final. removed stream other two are final now 3) Some typos in the constructor JavaDoc (and "operation" -> "operations" in the class JavaDoc). fixed typos 4) In skip, I don't think InputStream.skip is allowed to return < 0, and so the if (ret > 0) could be removed. It is not incorrect to have it, it might just be unnecessary. fixed 5) Some trailing spaces on three "empty" lines. thanks for the review fixed > Assessing blob (when its linked to DVD stream, ie large blob) corrupts stream fetched prior to this access. > ----------------------------------------------------------------------------------------------------------- > > Key: DERBY-2812 > URL: https://issues.apache.org/jira/browse/DERBY-2812 > Project: Derby > Issue Type: Bug > Components: JDBC > Affects Versions: 10.2.2.0, 10.3.0.0 > Reporter: Anurag Shekhar > Assignee: Anurag Shekhar > Attachments: derby-2812-testsuites.diff, derby-2812.diff, derby-2812v2.diff, derby-2812v3.diff, Derby2806.java > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.