db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren" <m.v.lunte...@gmail.com>
Subject Re: [jira] Commented: (DERBY-2020) Change file option for syncing log file to disk from rws to rwd
Date Wed, 13 Jun 2007 14:17:54 GMT
On 6/13/07, Olav Sandstaa (JIRA) <jira@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/DERBY-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504155
]
>
> Olav Sandstaa commented on DERBY-2020:
> --------------------------------------
>
> Thanks a lot for writing the release note, Myrna.
>
> I think the release note look very good and I have only some minor comments:
>
> 1. If the VM supports "rws" it also supports "rwd" mode. So there are no reverting back
from "rwd" to "rws". The only case where Derby revert back from using "rwd" is due to a JVM
bug, and then Derby will revert back to use "rw" mode (since the bug is also present when
running with "rws"). I propose to change the last sentence in "Rationale for Change" from:
>
>   "Because not all JVMs support this mechanism, Derby will check if it can use this mechanism
and if not, it will revert back to using the "rws" and print an appropriate message indicating
same in derby.log"
>
> to
>
>   "Some JVMs have a bug in the support for "rws" and "rwd" mode. Derby will check for
this bug, and if it is detected, Derby will revert back to using "rw" mode and print an appropriate
message indicating this in derby.log".
>
> 2. For the same reason I propose that the second sentence in the "Application Changes
required" is changed from:
>
>   "If not, a message will be printed to derby.log:"
>
> to
>
>  "If Derby detects that your JVM has a bug in the support for "rwd", a message will be
printed to derby.log"
>
> (as it is written now it seems like this sentence would be written to derby.log every
time Derby does not use "rwd" mode. This is no correct. For JVMs older than 1.4.2 "rwd" is
not supported, but Derby will not write anything about this to the derby.log)
>
> 3. There is a "the the" typo in the second last sentence in the "Rationale for Change"
section.
>
> Let me know if you want me to upload a new version of the release note or if you incorporate
this.

Thx for looking at this...If you can upload a new version it I'd prefer it  :-)

But if you haven't done so by the time it gets lunch time in
California I'll take care of it this afternoon and resolve the issue.

Myrna

Mime
View raw message