db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2646) Cleanup of Clob control/support structures
Date Tue, 05 Jun 2007 14:56:25 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-2646:
-----------------------------------

    Attachment: derby-2646-06a-embedclob_clobstreamcontrol.stat
                derby-2646-06a-embedclob_clobstreamcontrol.diff

'derby-2646-06a-embedclob_clobstreamcontrol.diff' is the last planned patch for this issue.
It changes EmbedClob to use the new InternalClob interface, and updates ClobStreamControl
accordingly (basically removes functionality moved to StoreStreamClob).

A few comments on changes in ClobStreamControl:
 * I added a simple caching mechanism for the last character position accessed. The cache
simply stores the corresponding byte position. Its primary objective is to reduce the penalty
taken when writing/reading one byte/char at a time.

 * It no longer extends LOBStreamControl, but keeps a reference to an instance of it (composition).
This caused the addition of some methods that only forwards the calls to LOBStreamControl.

There will be a version 06b of this patch, which I plan to commit tomorrow morning, but I
wanted to give people a change to have a look. For the curious, I suggest applying the patch
and looking at the Java source files instead of the diff. The changes are partly very extensive.

What remains for 06b is any last minute changes I might see fit and the enabling of the tests.
Note that also this patch will have some shortcomings that have to be addressed through other
Jiras (for instance DERBY-2762 and the streaming issues).

All feedback is appreciated!

> Cleanup of Clob control/support structures
> ------------------------------------------
>
>                 Key: DERBY-2646
>                 URL: https://issues.apache.org/jira/browse/DERBY-2646
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2646-01a_trailing_space.diff, derby-2646-01a_trailing_space.stat,
derby-2646-02a-clob-reorg.diff, derby-2646-02a-clob-reorg.stat, derby-2646-03a-internalclob.diff,
derby-2646-04a-storestreamclob_utf8util.diff, derby-2646-04a-storestreamclob_utf8util.stat,
derby-2646-04b-storestreamclob_utf8util.diff, derby-2646-05a-tests.diff, derby-2646-05a-tests.stat,
derby-2646-05b-tests.diff, derby-2646-06a-embedclob_clobstreamcontrol.diff, derby-2646-06a-embedclob_clobstreamcontrol.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message