db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-2768) Do cleanup (closing stmts., conns.) on failures in jdbcapi/BlobClob4BlobTest.java
Date Wed, 06 Jun 2007 11:44:26 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501907
] 

Øystein Grøvlen commented on DERBY-2768:
----------------------------------------

I think this is a very usefule change.
I wonder whether it would be better to move the close statements to a finally block.  Then,
you do not have to duplicate the statements, and it will also be cleaned-up when a wrong SQLState
is received.

> Do cleanup (closing stmts., conns.) on failures in jdbcapi/BlobClob4BlobTest.java
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-2768
>                 URL: https://issues.apache.org/jira/browse/DERBY-2768
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.0.0
>         Environment: NA
>            Reporter: Ole Solberg
>            Assignee: Ole Solberg
>            Priority: Trivial
>         Attachments: 2768-1.diff, 2768-1.stat
>
>
> jdbcapi/BlobClob4BlobTest.java should cleanup when detecting failures ['fail("FAIL -
....");'].
> When failures occur, as when doing compatibility testing for Blob/Clob locator support,
failures will occur. 
> Missing cleanup makes following tests to fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message