db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kurt Huwig (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2747) Reply incorrectly handles read() returning -1
Date Wed, 13 Jun 2007 12:26:26 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kurt Huwig updated DERBY-2747:
------------------------------

    Attachment: patch-2747-2.diff

svn diff would have been too easy...I made it the old hard way by manually diffing. The new
patch was my by svn diff.

I made the change to the if - we code it the other way round as it is faster to understand.
In this example is makes not much difference, but think of a 3-liner with '!= null' at the
end.

I added a brief comment describing the reason for the 'if' and the Jira issue.

> Reply incorrectly handles read() returning -1
> ---------------------------------------------
>
>                 Key: DERBY-2747
>                 URL: https://issues.apache.org/jira/browse/DERBY-2747
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.2.2.0
>            Reporter: Kurt Huwig
>            Priority: Minor
>         Attachments: patch-2747-1.diff, patch-2747-2.diff
>
>
> If java/client/org/apache/derby/client/net/Reply.java encounters a EOF, i.e. reads -1
then it adds this value to the number of bytes read and prints an error message which reads
"-1 bytes read".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message