db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manish Khettry (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1623) Add ANSI TRIM implementation
Date Thu, 07 Jun 2007 03:30:27 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502197
] 

Manish Khettry commented on DERBY-1623:
---------------------------------------

Thanks for reviewing the code. All your points are valid and 1 is a pretty egregious mistake
on my part. As far as 4 goes-- yes, it does have to be in reservedKeyword but is there a problem
if its in miscBuiltinsCore? I needed to add the token there because the ansi trim is parsed
inside the characterValueFunction production which in turn is under the miscBuiltinsCore production.
Infact this comment in miscBuiltinsCore says:

 miscBuiltinsCore() are the core
	 * system, string and numeric functions.
	 * NOTE: date functions not currently considered
	 * core for purposes of the grammar since
	 * they can only be escaped when they appear
	 * as functions (not special registers).

So is trim not a core function?



> Add ANSI TRIM implementation
> ----------------------------
>
>                 Key: DERBY-1623
>                 URL: https://issues.apache.org/jira/browse/DERBY-1623
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Emmanuel Bernard
>            Assignee: Manish Khettry
>         Attachments: 1623-parser-guess.diff, 1623.patch.txt, AnsiTrimTest.java, compile_error.jj,
sqlgrammar.jj.diff
>
>
> JPA is requiring databases to support this ANSI feature esp the ability to chose the
trimmed character
> TRIM([ [ LEADING | TRAILING | BOTH ] [ chars ] FROM ] str)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message