db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anurag Shekhar (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2812) Assessing blob (when its linked to DVD stream, ie large blob) corrupts stream fetched prior to this access.
Date Fri, 15 Jun 2007 12:12:26 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anurag Shekhar updated DERBY-2812:
----------------------------------

    Attachment: derby-2812v3.diff

 1) Since AutoPositioningStream extends BinaryToRawStream, can we be sure a non-store stream
is never passed in? What's the consequence if it happens? (i.e. will the length be set to
undetermined, or will the RawToBinaryStream fail?) I do see there is an assert in EmbedBlob,
I was 
In this patch derby-2812v3.diff i have addressed Kristian's comments
1. Enforcing PositionedStoreStream in AutoPositioningStream using SanityMagaer.assert

 2) I think conChild, positionedStream and stream can be made final.
removed stream other two are final now
 
 3) Some typos in the constructor JavaDoc (and "operation" -> "operations" in the class
JavaDoc).
fixed typos

 4) In skip, I don't think InputStream.skip is allowed to return < 0, and so the if (ret
> 0) could be removed. It is not incorrect to have it, it might just be unnecessary.

fixed

 5) Some trailing spaces on three "empty" lines.

thanks for the review
fixed

> Assessing blob (when its linked to DVD stream, ie large blob) corrupts stream fetched
prior to this access.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2812
>                 URL: https://issues.apache.org/jira/browse/DERBY-2812
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.2.2.0, 10.3.0.0
>            Reporter: Anurag Shekhar
>            Assignee: Anurag Shekhar
>         Attachments: derby-2812-testsuites.diff, derby-2812.diff, derby-2812v2.diff,
derby-2812v3.diff, Derby2806.java
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message