db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2604) Implement Clob support for locators
Date Mon, 04 Jun 2007 13:00:37 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-2604:

    Derby Info:   (was: [Patch Available])

Looks good to me. Committed revision 544119.

A couple of minor nits:

The new field maxPos in ClobLocatorInputStream/Reader could be final, I think. (The same is
probably true for the clob and connection field, and for the corresponding fields in the Blob
streams, but those classes/fields were not touched by your patch.)

Since there are both JDBC positions (counting from 1) and stream positions (counting from
0) in the stream classes, it would be good if maxPos's javadoc said where maxPos started counting

In Clob.positionX(), I think that it would be clearer if the code that increments index by
1 for non-locator lobs were moved into the else block right above it. (Then we don't need
to check isLocator() twice.)

Also in Clob.positionX(), I think the index variable should be changed to a long. As it is
now, clobGetPositionFromLocator() returns a long which is cast to int before it is cast back
to long and returned. It's better to keep it as a long all the way.

> Implement Clob support for locators
> -----------------------------------
>                 Key: DERBY-2604
>                 URL: https://issues.apache.org/jira/browse/DERBY-2604
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>             Fix For:
>         Attachments: ClobLocatorWork_v1.diff, ClobLocatorWork_v1.stat, ClobLocatorWork_v2.diff,
ClobLocatorWork_v2.stat, ClobLocatorWork_v3.diff, ClobLocatorWork_v3.stat, ClobLocatorWork_v4.diff,
ClobLocatorWork_v4.stat, ClobLocatorWork_v5.diff, ClobLocatorWork_v5.stat, ConnectionLocatorWork_v2.diff,

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message