Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (herse.apache.org: local policy)
Date: Sat, 19 May 2007 19:37:55 +0200
From: Knut Anders Hatlen <Knut.Hatlen@Sun.COM>
Subject: Re: Status of encodingTests
In-reply-to: <464F1055.80009@sun.com>
Sender: Knut.Hatlen@Sun.COM
To: derby-dev@db.apache.org
Message-id: <x7d50www7g.fsf@Sun.COM>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 8BIT
References: <464EF841.5080903@sun.com> <x7hcq97wqv.fsf@Sun.COM>
 <464F1055.80009@sun.com>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1.50 (usg-unix-v)

�ystein Gr�vlen <Oystein.Grovlen@Sun.COM> writes:

> Knut Anders Hatlen wrote:
>> �ystein Gr�vlen <Oystein.Grovlen@Sun.COM> writes:
>>
>>> What is the current status of encodingTests in the old test suite?
>>> DERBY-2568 mentions that it has been reported to be invalid.
>>
>> I think there are strong arguments for removing the entire suite. It has
>> also been discussed in DERBY-2446.
>>
>>> The reason I ask is that when I run with locators for Blob, derbyall
>>> fails in TestPreparedStatementMethods.  This test has been converted
>>> to JUnit and called PreparedStatementTest.  I assume the reason it is
>>> still run in the old harness is the encoding tests.  In order to get
>>> derbyall to run without failures with locators, I would have to fix
>>> the same issues that I have already fixed for PreparedStatementTest.
>>> That would be a waste of time if the encoding tests are not valid.
>>
>> Is it still part of the encodingTests suite? derbynet/TestEnc.java is
>> the only test mentioned in encodingTests.runall.
>
> You are right.  My conclusions were wrong.  It turns out the test is
> run in the ordinary jdbc40 suite.  This suite is still run (both
> embedded and client) even if it seems all its tests have been
> converted to JUnit. I will file a JIRA for removing them.  Please,
> tell me if there is a good reason for still running them in the old
> test framework.

PreparedStatementTest was added in DERBY-1333, and the description of
the patch said:

  b) jdbcxa40.runall contains one entry as of now of the
  PreparedStatementTest.junit which is the TestPreparedStatementMethods
  test converted to junit and which is also added as part of this patch
  ...
  d) PrepaerdStatementTest.java which is the jdbc40 PreparedStatements
  converted to junit

I guess it was just an oversight that the old test wasn't removed.

-- 
Knut Anders