Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <3223942.1178893995703.JavaMail.jira@brutus>
Date: Fri, 11 May 2007 07:33:15 -0700 (PDT)
From: "V.Narayanan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-2604) Implement Clob support for locators
In-Reply-To: <573529.1178195715363.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.Narayanan updated DERBY-2604:
-------------------------------

    Attachment: ClobLocatorWork_v3.stat
                ClobLocatorWork_v3.diff

I discussed this patch with knut and came to the conclusion that the check (off+len<0) (in ClobLocatorWriter and ClobLocatorOutputStream) was redundant because  if off+len overflows, and off>=0 and len>=0 and c.length>=0 and c.length <= Integer.MAX_VALUE, then (len > c.length - off) is always true. (Thanks to knut for pointing this out)

I am submitting a patch with this reduntant check removed.

I haven't run any tests with the new patch(with the check removed). The patch with this check did not give any failures. So I think this is OK. Also the locator code is not enabled yet and hence I do not expect any test failures.

Pls consider v3 for reviews and comments and if everything is ok a commit too.

> Implement Clob support for locators
> -----------------------------------
>
>                 Key: DERBY-2604
>                 URL: https://issues.apache.org/jira/browse/DERBY-2604
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: ClobLocatorWork_v1.diff, ClobLocatorWork_v1.stat, ClobLocatorWork_v2.diff, ClobLocatorWork_v2.stat, ClobLocatorWork_v3.diff, ClobLocatorWork_v3.stat, ConnectionLocatorWork_v2.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.