Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <16633093.1178268255578.JavaMail.jira@brutus>
Date: Fri, 4 May 2007 01:44:15 -0700 (PDT)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-2222) 'show indexes in SCHEMANAME' does
 not work with the client driver
In-Reply-To: <19108403.1168335267708.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/DERBY-2222?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493618 ]=20

Kristian Waagan commented on DERBY-2222:
----------------------------------------

I'm considering committing the v2 patch, but have a few comments. The tests=
 run cleanly, so the comments are more like nits.

 1) Some new code seem to be mixing tabs and spaces for indentation. The cu=
rrent guidelines can be found here: http://www.nabble.com/-VOTE---Approve-c=
oding-conventions-for-the-Derby-project-p5771191.html. I always use spaces =
if I change more than a few consecutive lines, even if the rest of the file=
 has tabs.

 2) Lines longer than 80 characters.

 3) The name of the methods 'getDisplayColumns' and 'getColumnWidths' are v=
ery generic, where as their comments indicate they are special methods that=
 are only used for displaying index information. Can the names or the comme=
nts be changed (as appropriate) to be more in agreement?

 4) The comment " //TODO: may want to change tabletype" in 'ij.jj' doesn't =
make much sense to me. Do I need to study the code to figure out what it me=
ans, or can it be made clearer/removed?

 5) For empty method bodies, it might be nice with a one-liner explaining w=
hy it is empty. For instance, I assume the method 'clearSQLWarnings' in 'ij=
MultipleResultSetResult.java' is a no-op because it can't get any warnings.

 6) The class 'ijMultipleResultSetResult' does not follow common naming gui=
delines for Java classes, since the start of the name is in lower case. I o=
bserve that this is the case for quite a lot of the files in the java/tools=
 directories.

 7) I wasn't able to quickly determine if the modified test (ij7.sql) is ru=
n with the client driver. Do you know? I did search a derbyall_pass.txt fil=
e (on a run with no errors), but only found the test listed once.


I'll wait a little for feedback on my comments before I commit.

thanks,

> 'show indexes in SCHEMANAME' does not work with the client driver
> -----------------------------------------------------------------
>
>                 Key: DERBY-2222
>                 URL: https://issues.apache.org/jira/browse/DERBY-2222
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Tools
>    Affects Versions: 10.2.2.0, 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: J=C3=B8rgen L=C3=B8land
>         Attachments: DERBY-2222-1.diff, DERBY-2222-1.stat, DERBY-2222-2.d=
iff, DERBY-2222-2.stat, ijMultipleResultSetResult.java
>
>
> The ij command 'show indexes in SCHEMANAME' does not work at all with the=
 client driver.
> It does work with the embedded driver.
> Sample output from ij:
> ij> connect 'jdbc:derby://localhost/myDB;create=3Dtrue';
> ij> create table test (id int primary key);
> 0 rows inserted/updated/deleted
> ij> show indexes in app;
> ERROR XJ103: Table name can not be null
> ij> show indexes from test;
> TABLE_NAME          |COLUMN_NAME         |NON_U&|TYPE|ASC&|CARDINA&|PAGES
> -------------------------------------------------------------------------=
---
> TEST                |ID                  |0     |3   |A   |NULL    |NULL
> 1 row selected
> ij> show indexes from app.test;
> TABLE_NAME          |COLUMN_NAME         |NON_U&|TYPE|ASC&|CARDINA&|PAGES
> -------------------------------------------------------------------------=
---
> TEST                |ID                  |0     |3   |A   |NULL    |NULL
> 1 row selected
> ij>
> Using delimited table and/or schema names does not work, but I think this=
 is according to documentation.
> I.e.:
> ij> show indexes from "TEST";
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij> show indexes from "APP".test;
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij> show indexes from "APP"."TEST";
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij>

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.