db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1465) NetworkServerControl.start() should throw an exception and not just print exceptions if the server fails to start
Date Tue, 22 May 2007 23:54:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498061
] 

Kathey Marsden commented on DERBY-1465:
---------------------------------------

Dan asked:
>Could you also explain the lifetime of this new thread then?
>Does this change mean that starting the network server now has an extra Thread for the
lifetime of the network server? 

No.  We used to start with DRDAServerStarter which made a thread to start network server.
Now NetworkServerControl

old:
NetworkServerControl.start() called DRDAServerStarter which started a thread calling blockingStart.
 blockingStart would log any exceptions.

new:
NetworkServerControl.start() creates its own thread calling blockingStart and throws any exceptions
that occur during the startup phase.  To determine the end of the startup phase it waits on
serverStartComplete. 
If start is  successful ...
 When blockingStart gets to the point that it would print the server is up, it notifies serverStartComplete
so the start method can return or throw any exception that occurred and waits to be shutdown.

If start fais....
blockingStart will throw an exception, notify serverStartComplete  and the thread will end.



> NetworkServerControl.start() should throw an exception and not just  print  exceptions
 if the server fails to start
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1465
>                 URL: https://issues.apache.org/jira/browse/DERBY-1465
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.1.2.1
>            Reporter: Kathey Marsden
>         Assigned To: Kathey Marsden
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-1465_diff.txt, DERBY-1465_diff.txt, DERBY-1465_stat.txt, DERBY-1465_stat.txt,
releaseNote.html
>
>
> NetworkServerControl.start()  will not throw an exception  if another server is already
running on the same port.    I am not sure but think perhaps this was changed at  one point
to accomodate the derby.drda.startNetworkServer property  so that the embedded server could
continue to boot even if the network server failed to start, but  I think this is wrong for
normal usage.
> http://www.nabble.com/Questions-about-Network-Server-API-Behavior-p5055814.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message