db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mayuresh Nirhali <Mayuresh.Nirh...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Date Wed, 30 May 2007 09:41:15 GMT
Please look at, Derby-1355.

As part of the test fix, I have modified LangHarnessTest to run AIjdbc 
test in CLIENT mode as well. The patches are ready for review.

There is a test fix proposed through DERBY-1355 and JUnit conversion 
proposed through this bug.
I think, these 2 activities can be handled in following different ways,

1. Wait for 1355 to be committed and then produce a new patch based on 
that change for this bug.
2. 1355 test fix is separated in a different patch. After review, do not 
commit the test patch. Instead, make necessary changes (Test running in 
CLIENT mode as well)  in the patch for 2726.
3. Create a patch for this bug without making the test runnable in 
CLIENT mode, wait for commit. Update the converted test to be run in 
CLIENT mode with a new patch for DERBY-1355.

Please let me know what will be the most preferred way.
I will make changes accordingly to 1355.


Regards
Mayuresh

Kathey Marsden (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499957
] 
>
> Kathey Marsden commented on DERBY-2726:
> ---------------------------------------
>
> Thanks Ugo for converting the test.
> The mention of EMBEDDED on the Wiki page means that the old test is running in LangHarnessJavaTest
only in embedded mode.  It should be removed from org.apache.derbyTesting.functionTests.tests.lang.LangHarnessJavaTest
now that you are adding the new test. Also the old file AIjdbc.java should be removed.
>
> I think it would be good to run this test in client mode as well to get coverage for
the client driver for these ResultSetMetaData methods.   I also think it would be good to
move the test to the jdbc suite from lang.
> I think it was in the wrong suite to start with.  It would be nice to have some javadoc,
but  otherwise your test looks good to me.
>
>
>
>
>   
>> convert lang/AIjdbc.java to JUnit
>> ---------------------------------
>>
>>                 Key: DERBY-2726
>>                 URL: https://issues.apache.org/jira/browse/DERBY-2726
>>             Project: Derby
>>          Issue Type: Test
>>          Components: Test
>>            Reporter: Ugo Matrangolo
>>            Assignee: Ugo Matrangolo
>>            Priority: Minor
>>         Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>>
>>
>>     
>
>
>   


Mime
View raw message