db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2604) Implement Clob support for locators
Date Sat, 26 May 2007 16:23:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

V.Narayanan updated DERBY-2604:
-------------------------------

    Attachment: ClobLocatorWork_v5.stat
                ClobLocatorWork_v5.diff

This patch addresses the bugs that were found during the process of enabling 
Clob support for locators. It contains within itself the changes made in v4
and the changes as explained in the comments above.

The following are the details of the details of the files modified and their
import apropos the context.

M      java/client/org/apache/derby/client/am/ClobLocatorWriter.java

writeCharacters(line no 162) method was using c.length as the length of the string
transmitted to the server using the clobSetString stored procedure. This should
use len instead.

M      java/client/org/apache/derby/client/am/Clob.java

The PositionX method on the client that accepts a Clob had not been converted to use 
locators. This has been done.

Added buffering for InputStreams by wrapping ClobLocatorInputStream in
a BufferedInputStream and ClobLocatorReader in a BufferedReader.

M      java/client/org/apache/derby/client/am/CallableLocatorProcedures.java

The stored procedure call to CLOBGETPOSITIONFROMSTRING was sending the original string 
instead of sending it in chunks. This has been changed to send the chunks instead
(stringToBeCompared).

M      java/client/org/apache/derby/client/am/ClobLocatorInputStream.java
M      java/client/org/apache/derby/client/am/ClobLocatorReader.java

Converted the locator streams to use maxPos in the same way this is done
in BlobLocatorInputStream.

I have not run junit All on the patch yet. I will run the tests and revert back with
the results.

Please consider v5 for reviews and comments.

> Implement Clob support for locators
> -----------------------------------
>
>                 Key: DERBY-2604
>                 URL: https://issues.apache.org/jira/browse/DERBY-2604
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: ClobLocatorWork_v1.diff, ClobLocatorWork_v1.stat, ClobLocatorWork_v2.diff,
ClobLocatorWork_v2.stat, ClobLocatorWork_v3.diff, ClobLocatorWork_v3.stat, ClobLocatorWork_v4.diff,
ClobLocatorWork_v4.stat, ClobLocatorWork_v5.diff, ClobLocatorWork_v5.stat, ConnectionLocatorWork_v2.diff,
ConnectionLocatorWork_v4.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message