db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2604) Implement Clob support for locators
Date Wed, 09 May 2007 12:52:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494489
] 

V.Narayanan commented on DERBY-2604:
------------------------------------

thanx a ton for taking a look at the patch and commenting on it Oystein 
and Knut!

1) Thank you for the suggestion on the conversion to ASCII.
    I think you are correct and I will do it the same way.

2) The behaviour on Close() is not uniform in the streams returned from Lobs
     in the server and client.

    For example in am/ClobWriter close does this

    public void close() throws java.io.IOException {
    }

    while on the embedded side impl/jdbc/ClobUtf8Writer close() is this
   
    /**
     * Closes the stream, flushing it first. Once the stream has been 
closed,
     * further write() or flush() invocations will cause an IOException 
to be
     * thrown. Closing a previously closed stream has no effect.
     */
    public void close() {
        closed = true;
    }

    I intend to leave close() as it is currently implemented in the 
locator streams
    unless there is objection to this.

3) In the writeBytes(byte b[]) method line no 66 
am/ClobOutputStream.java I found this
     conversion from byte to String
  
    String str = new String(b, "US-ASCII");

    I am not sure if both the contexts match but seems like it.
    




> Implement Clob support for locators
> -----------------------------------
>
>                 Key: DERBY-2604
>                 URL: https://issues.apache.org/jira/browse/DERBY-2604
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: ClobLocatorWork_v1.diff, ClobLocatorWork_v1.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message